Conversation
|
Alright we have 5 fails in #1371, same as I did back in Dec: Fiddly Cypress issue:
These seem like real issues, all 3 show 403s instead of 200s when trying to get activity:
Replicating locally, the error for the above 3 is Looking back, I see that in Dec I added and then removed My notes captured that users should NOT be able to view @ikethecoder do you remember why we removed the change to add that permission on gateway creation? Do we want to A) modify/remove these tests, B) grant the Namespace.View scope manually in the tests so they pass, or C) grant .View on ns creation. ? I'm leaning towards B. There is also a build error now, which is reproducible locally when running |
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
I can't recall why - but I agree option B. I think we had talked about a "more correct" solution is to configure the |
|
🔔 Friendly reminder: The following reviewers still need to review this PR: @rustyjux, @phowells, @Elson9, @danebenal PS: @sdqdadat |
PR Summary
Keycloak 15 → 26 upgrade support
Keycloak service layer
client-service,client-policy-service,client-registration-service,client-roles,group-service,user-service,namespace-details,token-service, and related org-group/UMA services to align with Keycloak 26 APIs and behavior.Realm and local Keycloak setup
local/keycloak/master-realm.jsonfor Keycloak 26 schema/fields.local/keycloak/Dockerfilefor Keycloak 26 andlocal/keycloak/nginx-lb.conffor the new deployment topology.OAuth2-proxy and auth integration
src/auth/auth-oauth2-proxy.js,src/auth/auth-tsoa.ts, and addedsrc/auth/forbidden-error.tsfor Keycloak 26 token handling and forbidden responses.local/oauth2-proxy/.E2E and tests for Keycloak 26
src/test/mocks/handlers/data/keycloak.yaml,src/test/mocks/handlers/keycloak.ts) and integrated Keycloak/org-groups tests.Other changes
CI and test tooling
Local/dev environment
docker-compose, local Dockerfiles (Kong, portal, E2E), DB/Keystone init scripts, and.env.local/.nvmrc.App and dependencies
src/🚀 Feature branch deployment: https://api-services-portal-feature-kc-26.apps.silver.devops.gov.bc.ca